dbConnect creates two connections, one of which is orphaned

[amarek96]

Method "dbConnect" creates two connection, one of which is orphaned. The method first invokes java.sql.DriverManager.getConnection(), which creates the first connection. The following if-statement checks if jc is null OR drv@jdrv is not null. Instead of OR it should be AND, i.e. if (is.jnull(jc) && !is.jnull(drv@jdrv)).

The OR incorrectly lets dbConnect enter the if-statement if drv is not null and thus create a second (duplicate) connection with java.sql.Driver.connect(). For example:

drv = JDBC("com.teradata.jdbc.TeraDriver","c:\terajdbc\terajdbc4.jar;c:\terajdbc\tdgssconfig.jar")
con = dbConnect(drv,"jdbc:teradata://system","user","password")
dbDisconnect(con)

The dbDisconnect will only close one of the two connections created by dbConnect.