🩹Fix broken deployment build #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since version 3.0.0 doesn't work with webpack 5. Ref: GoogleChromeLabs/size-plugin#40 (comment)
…rkflow Fixes the Error: $ npm run update_manifest_firefox > @ update_manifest_firefox /home/runner/work/binge-stream/binge-stream > npx ts-node tools/firefox_manifest_append.ts npx: installed 14 in 2.154s (node:1884) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension. (Use `node --trace-warnings ...` to show where the warning was created) Cannot use import statement outside a module npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! @ update_manifest_firefox: `npx ts-node tools/firefox_manifest_append.ts` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the @ update_manifest_firefox script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 48.00% 48.00%
=======================================
Files 5 5
Lines 100 100
Branches 18 18
=======================================
Hits 48 48
Misses 49 49
Partials 3 3 Continue to review full report at Codecov.
|
s-weigand
force-pushed
the
fix-build
branch
2 times, most recently
from
f51848b
to
7fb5e4b
Compare
s-weigand
force-pushed
the
fix-build
branch
from
7fb5e4b
to
7adc517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
https://github.com/s-weigand/binge-stream/runs/3570279099?check_suite_focus=true
Problems were:
size-pluginnot being compatible with webpack 5ts-nodeneeding additional config to work with ES module style imports