-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🩹 Fix config file discovery #255
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.25%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
8c7d0d6
to
6f48511
Compare
Codecov Report
@@ Coverage Diff @@
## main #255 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 429 431 +2
Branches 74 74
=========================================
+ Hits 429 431 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6f48511
to
e240239
Compare
Besides
"flake8"
being hardcoded inflake8.options.config
so is the config file name".flake8"
which needs to be replaces with".flake8_nb"
to prevent a regression where".flake8_nb
is ignored.The other problem with the discovery of config files was that the config discovery happens in
Application.initialize
which means that the runtime module replacement needs to happen before this and theconfig
module also needs to be replaced inside offlake8.main.application
.closes #254