FIX: gets local time instead of utc0 time #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change, so probably should be added as another time component instead of changing the behaviour of the existing one. |
|
Yes indeed. I could write it to use the name LocalTime instead. Whats the best Name for it? |
|
LocalTime is a good suggestion, thanks. |
|
Should the LocalTime be updated when updateTime() is called or should another Function be added as well? |
|
I would suggest both be updated from |
|
I have change on the local_time branch in my fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will get the local time based on the timezone reported by the device instead of utc0 which should make a lot more sense for this paticular use case