Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(streams): Handle nil record(s) returned by aws-sdk-go #28

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented May 28, 2018

Ref #27

@mumoshu mumoshu changed the title fix(streams): Hndle nil record(s) returned by aws-sdk-go fix(streams): Handle nil record(s) returned by aws-sdk-go May 28, 2018
@mumoshu mumoshu force-pushed the handle-panics-on-nil-record-returned-by-kinesis branch from 01f7924 to d3df0c8 Compare May 28, 2018 02:38
@codecov-io
Copy link

codecov-io commented May 28, 2018

Codecov Report

Merging #28 into master will decrease coverage by 0.84%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   33.89%   33.05%   -0.85%     
==========================================
  Files           4        4              
  Lines         118      121       +3     
==========================================
  Hits           40       40              
- Misses         71       74       +3     
  Partials        7        7
Impacted Files Coverage Δ
streams/client.go 24.39% <0%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac4f11...d3df0c8. Read the comment docs.

@mumoshu
Copy link
Collaborator Author

mumoshu commented May 30, 2018

Closing this in favor of #31. I've consolidated this into #31 and added tests there.

@mumoshu mumoshu closed this May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants