add a test

s12v · Dec 9, 2018 · 0f487a1 · 0f487a1
1 parent 96cfbba
commit 0f487a1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/provider/awskms/awskms.go b/provider/awskms/awskms.go
@@ -45,16 +45,16 @@ func (p *KmsProvider) Match(val string) bool {
 func (p *KmsProvider) Decode(val string) (string, error) {
 	blob, err := base64.StdEncoding.DecodeString(val[len(prefix):])
 	if err != nil {
-		return val, err
+		return "", err
 	}
 
 	input := &kms.DecryptInput{CiphertextBlob: blob}
 	if err = input.Validate(); err != nil {
-		return val, nil
+		return "", err
 	}
 
 	if output, err := decrypt(p.awsKmsClient, input); err != nil {
-		return val, err
+		return "", err
 	} else {
 		return string(output.Plaintext), nil
 	}

diff --git a/provider/awskms/awskms_test.go b/provider/awskms/awskms_test.go
@@ -32,3 +32,10 @@ func TestKmsProvider_Decode(t *testing.T) {
 		t.Fatalf("unexpected plaintext %v", r)
 	}
 }
+
+func TestKmsProvider_DecodeInvalid(t *testing.T) {
+	kmsProvider := KmsProvider{}
+	if _, err := kmsProvider.Decode("{aws-kms}"); err == nil {
+		t.Fatal("expected an error")
+	}
+}