Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Crash on Round End + SV_RESTART + USER_KILL #219

Closed
ghost opened this issue Nov 22, 2017 · 4 comments
Closed

Server Crash on Round End + SV_RESTART + USER_KILL #219

ghost opened this issue Nov 22, 2017 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 22, 2017

https://forums.alliedmods.net/showthread.php?p=2562176#post2562176

@In-line In-line added bug and removed bug labels Nov 22, 2017
@In-line
Copy link
Collaborator

In-line commented Nov 22, 2017

I was unable to reproduce crash. It seems that problem is in your code.

@ghost
Copy link
Author

ghost commented Nov 22, 2017

You probably do something wrong, HamletEagle also managed to reproduce the crash, he also tested on linux and the outcome is the same

Steps to reproduce

  • Join the game
  • set mp_roundtime to 1
  • set mp_freezetime to 0
  • set sv_restart to 1
  • Now you will either get stuck in a round end loop or it will crash

Alternative

  • set mp_roundtime to 1 ( from .cfg file )
  • set mp_freezetime to 0 ( from .cfg file )
  • Join the game
  • Wait for the round to end
  • Now both the client and the server shall crash

Usually without ReHLDS and ReGame you will be stuck in a loop
ReHLDS

  • 1291
    ReGame
  • 5.3.0.270 dev
    Amxmodx
  • 5144 dev
    OS
  • Windows + Linux

@In-line
Copy link
Collaborator

In-line commented Nov 22, 2017

@Depresie Was this your crash message?
PF_MessageBegin_I: New message started When msg 'X 'has not been sent yet

@ghost
Copy link
Author

ghost commented Nov 22, 2017

I couldn't read the error message, but HamletEagle figured out what the problem was..
Basically sending a message from a get_user_msgid hook is not a thing to do, he explained it here
https://forums.alliedmods.net/showthread.php?p=2562219#post2562219

When you try to kill the player, game is executing code from PlayerKilled and DeathNotice, which in turn are sending messages. But when you hook a message with register_message, it is not sent already, so most likely game tries to send another message while the previous one is not finished yet.

This issue can be closed, since it is not a bug, it actually works as intended.

@In-line In-line closed this as completed Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant