Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rg_give_defusekit(): Add player team check #234

Merged
merged 2 commits into from Mar 31, 2023

Conversation

Giferns
Copy link
Contributor

@Giferns Giferns commented Nov 25, 2021

Add player team check to avoid unexpected behavior

fix #233

Add player team check to avoid unexpected behavior
Fix wrong team constant
@Giferns Giferns changed the title Update natives_misc.cpp rg_give_defusekit(): Add player team check Nov 25, 2021
@justgo97
Copy link
Contributor

What kind of unexpected behavior? you can Just do the check in the plugin you are using.

@Giferns
Copy link
Contributor Author

Giferns commented Nov 25, 2021

@justgo97 so, for what reason we have CHECK_ISPLAYER(), CHECK_CONNECTED(), m_bMapHasBombTarget and m_bMapHasBombZone checks in the same function? According to your logic, then we need to check almost everything in plugins.

What kind of unexpected behavior
body will be set to 1 so TT player will have backpack on the back. I faced this "bug" several times, and it can be not very easy to resolve.

@wopox1337 wopox1337 changed the title rg_give_defusekit(): Add player team check rg_give_defusekit(): Add player team check Dec 28, 2021
@wopox1337 wopox1337 self-requested a review December 28, 2021 15:33
@s1lentq s1lentq merged commit ac3d641 into s1lentq:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check player team for rg_give_defusekit
4 participants