fix(floating-big-letter): calculate max width #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of calculating width based on 2nd index of a line, we calculate it based on the longest length instead. Without it, we have rendering issues on "wide" characters being forcibly wrapped. This enables future support of custom fonts via `figlet` or `toilet`. Fixes: s1n7ax#69
|
Very nice change, but seem like plugin author is too busy |
s1n7ax
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calculating width based on 2nd index of a line, we calculate it based on the longest length instead. Without it, we have rendering issues on "wide" characters being forcibly wrapped.
This enables future support of custom fonts via
figletortoilet.Fixes: #69
Before
After