Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit ownership for all resources #2261

Open
gaul opened this issue Aug 13, 2023 · 0 comments
Open

Use explicit ownership for all resources #2261

gaul opened this issue Aug 13, 2023 · 0 comments

Comments

@gaul
Copy link
Member

gaul commented Aug 13, 2023

C++11 enables s3fs to manage resources explicitly, e.g., via std::unique_ptr and std::move, instead of ad-hoc management via delete. This can simplify error handling and we can eliminate most or maybe all calls to delete.

We should be able to write some wrappers for FILE* and file descriptors as well.
gaul added a commit to gaul/s3fs-fuse that referenced this issue Aug 14, 2023
@gaul
Simplify xattr_value with owned values
22d7bff 
References s3fs-fuse#2261.
@gaul gaul mentioned this issue Aug 14, 2023
Merged
gaul added a commit to gaul/s3fs-fuse that referenced this issue Aug 14, 2023
@gaul
Simplify xattr_value with owned values
334d747 
References s3fs-fuse#2261.
ggtakec pushed a commit that referenced this issue Aug 15, 2023
@gaul
Simplify xattr_value with owned values (#2262)
67e6b9e 
References #2261.
gaul added a commit to gaul/s3fs-fuse that referenced this issue Aug 16, 2023
@gaul
Return std::unique_ptr from S3fsCurl callbacks
ab9aa47 
References s3fs-fuse#2261.
@gaul gaul mentioned this issue Aug 16, 2023
Merged
gaul added a commit to gaul/s3fs-fuse that referenced this issue Aug 16, 2023
@gaul
Return std::unique_ptr from S3fsCurl callbacks
360918b 
References s3fs-fuse#2261.
gaul added a commit to gaul/s3fs-fuse that referenced this issue Aug 16, 2023
@gaul
Return std::unique_ptr from S3fsCurl callbacks
e75ed15 
References s3fs-fuse#2261.
ggtakec pushed a commit that referenced this issue Aug 17, 2023
@gaul
Return std::unique_ptr from S3fsCurl callbacks (#2272)
7f30353 
References #2261.
gaul added a commit to gaul/s3fs-fuse that referenced this issue Aug 19, 2023
@gaul
Use unique_ptr in SSL functions
ed6cf96 
References s3fs-fuse#2261.
@gaul gaul mentioned this issue Aug 19, 2023
Merged
gaul added a commit to gaul/s3fs-fuse that referenced this issue Aug 19, 2023
@gaul
Use unique_ptr in SSL functions
2fdbef5 
References s3fs-fuse#2261.
ggtakec pushed a commit that referenced this issue Aug 19, 2023
@gaul
Use unique_ptr in SSL functions (#2282)
7e94b64 
References #2261.
gaul added a commit to gaul/s3fs-fuse that referenced this issue Sep 12, 2023
@gaul
Store mvnode in vector instead of manual linked list
b92a766 
This simplifies code and avoids manual memory management.  References s3fs-fuse#2261.
@gaul gaul mentioned this issue Sep 12, 2023
Merged
gaul added a commit to gaul/s3fs-fuse that referenced this issue Sep 12, 2023
@gaul
Add scope_guard for ad-hoc resource management
3944f52 
References s3fs-fuse#2261.  Suggested by:
https://stackoverflow.com/questions/10270328/the-simplest-and-neatest-c11-scopeguard
@gaul gaul mentioned this issue Sep 12, 2023
Merged
gaul added a commit to gaul/s3fs-fuse that referenced this issue Sep 12, 2023
@gaul
Add scope_guard for ad-hoc resource management
84eac00 
References s3fs-fuse#2261.  Suggested by:
https://stackoverflow.com/questions/10270328/the-simplest-and-neatest-c11-scopeguard
gaul added a commit to gaul/s3fs-fuse that referenced this issue Sep 12, 2023
@gaul
Add scope_guard for ad-hoc resource management
8b2bee7 
References s3fs-fuse#2261.  Suggested by:
https://stackoverflow.com/questions/10270328/the-simplest-and-neatest-c11-scopeguard
ggtakec pushed a commit that referenced this issue Sep 13, 2023
@gaul
Store mvnode in vector instead of manual linked list (#2312)
01189e9 
This simplifies code and avoids manual memory management.  References #2261.
gaul added a commit to gaul/s3fs-fuse that referenced this issue Sep 15, 2023
@gaul
Use std::unique_ptr in libxml functions
23b6e98 
References s3fs-fuse#2261.
@gaul gaul mentioned this issue Sep 15, 2023
Merged
gaul added a commit to gaul/s3fs-fuse that referenced this issue Sep 15, 2023
@gaul
Use std::unique_ptr in libxml functions
a9116d3 
References s3fs-fuse#2261.
gaul added a commit to gaul/s3fs-fuse that referenced this issue Sep 15, 2023
@gaul
Use std::unique_ptr in libxml functions
36bb0bc 
References s3fs-fuse#2261.
gaul added a commit to gaul/s3fs-fuse that referenced this issue Sep 15, 2023
@gaul
Use std::unique_ptr for fclose
e36d746 
References s3fs-fuse#2261.
gaul added a commit to gaul/s3fs-fuse that referenced this issue Sep 15, 2023
@gaul
Add scope_guard for ad-hoc resource management
78975fb 
References s3fs-fuse#2261.  Suggested by:
https://stackoverflow.com/questions/10270328/the-simplest-and-neatest-c11-scopeguard
@gaul gaul mentioned this issue Sep 15, 2023
Merged
gaul added a commit to gaul/s3fs-fuse that referenced this issue Sep 15, 2023
@gaul
Use std::unique_ptr for fclose
fb9ba31 
References s3fs-fuse#2261.
gaul added a commit that referenced this issue Sep 24, 2023
@gaul
Use std::unique_ptr for fclose
cd25674 
References #2261.
gaul added a commit that referenced this issue Sep 24, 2023
@gaul
Use std::unique_ptr in libxml functions
ccc4079 
References #2261.
gaul added a commit that referenced this issue Sep 24, 2023
@gaul
Use std::unique_ptr in libxml functions
e5260d4 
References #2261.
gaul added a commit that referenced this issue Sep 24, 2023
@gaul
Use std::unique_ptr for fclose
7b86a41 
References #2261.
ggtakec pushed a commit that referenced this issue Sep 25, 2023
@gaul
Use std::unique_ptr in libxml functions (#2317)
c5fb42f 
References #2261.
ggtakec pushed a commit that referenced this issue Sep 25, 2023
@gaul
Use std::unique_ptr for fclose (#2318)
61df7bf 
References #2261.
gaul added a commit to gaul/s3fs-fuse that referenced this issue Sep 25, 2023
@gaul
Add scope_guard for ad-hoc resource management
1161a3e 
References s3fs-fuse#2261.  Suggested by:
https://stackoverflow.com/questions/10270328/the-simplest-and-neatest-c11-scopeguard
ggtakec pushed a commit that referenced this issue Sep 25, 2023
@gaul
Add scope_guard for ad-hoc resource management (#2313)
361e10d 
References #2261.  Suggested by:
https://stackoverflow.com/questions/10270328/the-simplest-and-neatest-c11-scopeguard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaul