-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added several memory checks to CI #2173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really excited for this change which should prevent many regressions.
@gaul I changed some and squash code, please re-review it.
|
525f119
to
609660c
Compare
I changed the |
I added |
Let's remove valgrind for now and just go with the tests that are successful? The sanitizers have good coverage. |
@gaul I post this as a PR as not Draft. |
Thanks for integrating this! We have had several tsan regressions over the years and it will be nice to catch these during PR phase in the future. |
Relevant Issue (if applicable)
#2172
Details
I added some memory checking to CI process as same as
run_tests_using_sanitizers.sh
.Each test in
run_tests_using_sanitizers.sh
seem best to be a CI Job because all of test several patterns require execution from the build.The testing base container is Ubuntu:22.04.
This PR is first submitted as a Draft.