Fix extended attribute support when using FUSE-T #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Fishman <alex@fuse-t.org> Signed-off-by: alex <alex@alex-NUC10.lan>
Signed-off-by: Alex Fishman <alex@fuse-t.org>
ggtakec
approved these changes
Jun 26, 2023
|
@macos-fuse-t Thanks for your kindness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes extended attribute support when using FUSE-T.
Relevant Issue (if applicable)
Details
When libfuse receives an attribute size of 0, the pointer is not defined and should not be assumed to be NULL.
Relevant libfuse code:
struct fuse_setxattr_in *arg = (struct fuse_setxattr_in *) inarg;
char *name = PARAM(arg);
char *value = name + strlen(name) + 1;
...
req->f->op.setxattr(req, nodeid, name, value, arg->size, arg->flags, arg->position);