Fixed data race about fuse_fill_dir_t function and data pointer #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggtakec
force-pushed
the
fix_filler_datarace
branch
2 times, most recently
from
82e7899
to
bb4fc03
Compare
This was referenced Jul 13, 2023
Closed
ggtakec
force-pushed
the
fix_filler_datarace
branch
from
bb4fc03
to
f7cb1bb
Compare
ggtakec
force-pushed
the
fix_filler_datarace
branch
from
f7cb1bb
to
918cb78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
#2213 #2212
Details
In the thread callback handler for
HeadRequestcalled by FUSE readdir,void* bufandfuse_fill_dir_t fillerseem not suitable for asynchronous writes.I checked the FUSE source code, but it seems that exclusive control for
bufis not implemented byfiller.s3fs
HeadRequestsare processed in parallel by multithreading, so it seems that thisfillercall needs to be synchronized.However,
ThreadSanitizernever detected this part yet.(Even if exclusive control is performed in the
filler, I have decided that exclusive control on the s3fs side is not a particular problem, so I am submitting this PR.)This fix obsoletes
multi_head_callback_paramuses in threading functions and usesSyncFillerobjects instead.All data related to
fillerandbufare implemented inside theSyncFillerobject.(This includes
filledvariables added by #2212)SyncFillerobject handlesbuf/filler/filledsafely.