Fixed a bug upload boundary calculation in StreamUpload #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
s/SteamUpload/StreamUpload/ |
ggtakec
force-pushed
the
fix_streamupload
branch
from
f3668d6
to
f353717
Compare
ggtakec
force-pushed
the
fix_streamupload
branch
from
8040f8c
to
9076d9d
Compare
ggtakec
changed the title
I'm sorry for typo, I rebased it to master and also fixed the comments in the git log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
#2299
Details
Fixed the bug detected in #2299.
There was a problem in calculating the start position of the upload part during Streamupload, and it has been fixed.
We have also added a test case(
test_not_boundary_writes) to detect this defect.Although it is possible to include it in the
test_write_data_with_skiptest, I made it independent as a test case.Note
Currently, Github Action CI is failing for this PR due to a stat(cached) issue.