s3fs: make dir size not zero #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you actually test this? |
Yes, I compiled s3fs and mount a bucket, dir size becomes 4096 instead of 0 original drwxr-xr-x 1 root root 0 Feb 9 2023 testdirpatched drwxr-xr-x 1 root root 4096 Feb 9 2023 testdir |
|
So you ran |
Test fails because of "Error: Invalid or corrupt jarfile s3proxy-2.0.0", which doesn't seem related to my change. |
gaul
requested changes
Nov 17, 2023
Directory has size 0, which looks weired and may confuse users. So fake dir size as 4k. Signed-off-by: Eryu Guan <eguan@linux.alibaba.com>
|
Thank you for your contribution @eryugey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directory has size 0, which looks weired and may confuse users. So fake dir size as 4k.