Fixed a bug that mounting with ksmid specified to fail #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
#2401
Details
If the bucket(or directory under the bucket) user attempt to mount is not created as SSE, a GET request(with the
x-amz-server-side-encryptionheader) to check the mount point will return an error(InvalidArgument:x-amz-server-side-encryptionheader is not supported for this operation).Thus, if the bucket did not have SSE settings(get error response), I changed that s3fs retried to send the GET request without
x-amz-server-side-encryptionheader to check the mount point.@gaul
If there are multiple causes for an error when making a GET request to check a mount point, the error details will be returned in order on each attempt, so the trial processing has been changed to a loop and refactored.
(I have added this recovering code, but the basic logic has not changed.)
This is a PR that fixes a bug reported by @aczire.