Fixed a bug about mtime - #299 #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update content of the master to macosx branch.
ggtakec
added a commit
that referenced
this pull request
Nov 29, 2015
Fixed a bug about mtime - #299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s3fs had a bug(#299) that was s3fs could not set mtime to the file when the file was created with specifying mtime.
The bug occurred only if you started s3fs without cache files(not specified use_case option).
FUSE calls create/utimens/flush interface for s3fs when the file is created with mtime.
But utimens interface does not have file descriptor.
s3fs should search a fd from file path which is opened local file(cache).
But s3fs did not search it when s3fs was run without use_cache option.
This patch fixed it.
Be careful following:
If a file is created with mtime by some clients at same time on s3fs without use_cache, probably mtime for the file will be undefined.
This result is the same as the file content is undefined, s3fs is not guaranteed.