#691: Made instructions for creating password file more obvious. #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaul
reviewed
Sep 10, 2018
README.md
Outdated
| @@ -79,11 +79,11 @@ The default location for the s3fs password file can be created: | |||
| * using a .passwd-s3fs file in the users home directory (i.e. ~/.passwd-s3fs) | |||
| * using the system-wide /etc/passwd-s3fs file | |||
|
|
|||
| Enter your S3 identity and credential in a file `~/.passwd-s3fs` and set | |||
| Enter your AWS credentials in a file `~/.passwd-s3fs` and set | |||
There was a problem hiding this comment.
This wording is OK although s3fs supports non-AWS S3 implementations. Perhaps just say credentials here and ACCESS_KEY_ID and SECRET_ACCESS_KEY below?
There was a problem hiding this comment.
That makes sense, I'll make the change.
|
(Commits are squashed now). |
gaul
approved these changes
Sep 10, 2018
|
@soulprovidr @gaul Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
#691
Details
Updated language to eliminate confusion surrounding the credentials to use in the password file.