Normalize the extentions inside of config in-place #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename `update_extentions` to `Normalize_extentions` as it better conveys the intent; * Remove the unnecessary copy of the extensions vector; * Remove the unnecessary copy of the `RustusConf` object;
Kolaer
force-pushed
the
feature/optimize-config
branch
from
8c04624
to
805eb8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_extentionstoNormalize_extentionsas it better conveys the intent;RustusConfobject;By the way, is there any reason for the extensions to be sorted? I couldn't find any mention of that in the specification. I'd argue that it's better to drop this requirement if there's no reason for it and switch to
HashSetinstead ofVec. If it's required for any other reason, we can still switch toBTreeSet.