Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications for current buffer not showing up #22

Closed
mirkojovanovic opened this issue Feb 20, 2020 · 3 comments
Closed

Notifications for current buffer not showing up #22

mirkojovanovic opened this issue Feb 20, 2020 · 3 comments

Comments

@mirkojovanovic
Copy link

I have notify_for_current_buffer option set to on, however notifications for current buffer don't show up.

  • weechat version: 2.7
  • script installed trough /script
  • options set trough /fset
  • running on Arch Linux
@s3rvac
Copy link
Owner

s3rvac commented Feb 21, 2020

Hi. I think there is a misunderstanding about what the notify_for_current_buffer option does (maybe I have not chosen the best name for it). From the docs:

notify_for_current_buffer: Send also notifications for the currently active buffer. Default: on.

It means that notifications for the currently active buffer should not be suppressed. However, it does not mean that you will receive notifications for all messages in the active buffer. Is that what you are looking for? To receive a notification for all messages in the currently active buffer?

@mirkojovanovic
Copy link
Author

Yes, misunderstood the description. That's what I was looking for.

Seems useful to me. In case you don't want to recieve notifications from some channels, only if they are in active buffer. That way we could stay focused on the conversation of interest going, and check weechat only when neccessary, all while preventing overstimulation with so many notifications.

I love this script, thanks for writing it ;)

s3rvac added a commit that referenced this issue Feb 22, 2020
When set to `on`, you will receive a notification for all messages in the
currently active buffer.
@s3rvac
Copy link
Owner

s3rvac commented Feb 22, 2020

In commit 1c1092d, I have added a new config option notify_on_all_messages_in_current_buffer. Its default value is off. When set to on, you will receive a notification for all messages in the currently active buffer.

So, grab the current master version of the script, set the option to on, and enjoy 😉

@s3rvac s3rvac closed this as completed Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants