Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechat-notify-send is a WeeChat script, not a plugin #8

Closed
sim642 opened this issue Aug 28, 2017 · 1 comment
Closed

weechat-notify-send is a WeeChat script, not a plugin #8

sim642 opened this issue Aug 28, 2017 · 1 comment
Assignees
@s3rvac
Labels
bug

Comments

@sim642
Copy link

sim642 commented Aug 28, 2017

It is misleading for weechat-notify-send to call itself a WeeChat plugin because it is not one. WeeChat plugins are implemented in C and compiled. This, however, is a Python script, which is called a script in WeeChat.

It is important not to confuse the two because both are a thing in WeeChat but different. There are even different commands (/plugin vs /script) which need to be correctly used for things to work.
s3rvac added a commit that referenced this issue Aug 28, 2017
@s3rvac
Replace the word 'plugin' with 'script' (#8).
a883ff0 
Technically, weechat-notify-send is a script, not a plugin, see
https://weechat.org/files/doc/stable/weechat_scripting.en.html#differences_with_c_api
@s3rvac s3rvac self-assigned this Aug 28, 2017
@s3rvac
Copy link
Owner

s3rvac commented Aug 28, 2017

Thank you, I was not aware of that. I have updated the description, README, and source files to reflect WeeChat's nomenclature.

@s3rvac s3rvac closed this as completed Aug 28, 2017
@s3rvac s3rvac added the bug label Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s3rvac s3rvac

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sim642 @s3rvac