Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore_failed_copy should maybe be removed and replaced by stop_on_error #584

Closed
fviard opened this issue Jul 18, 2015 · 2 comments
Closed

Comments

@fviard
Copy link
Contributor

fviard commented Jul 18, 2015

There is the configuration entry:
"ignore_failed_copy"
that is used to continue processing a "s3cmd cp" / "s3cmd modify" / "s3cmd mv" ...
even when some src files doesn't exist in the s3 server "NoSuchKey".

It should certainly be removed and its use replaced by the new configuration "stop_on_error".
In that case the behavior of these functions will be inversed regarding when "ignore_failed_copy" was the default. But I think that it is not such a big deal for these functions in order to have consistency everywhere.

By the way, "subcmd_cp_mv" should probably be modified to return "EX_PARTIAL" if we are in the continue on error mode and we encounter one or more cases of NoSuchKey.

@fviard fviard assigned fviard and unassigned fviard Jul 18, 2015
@fviard
Copy link
Contributor Author

fviard commented Jul 18, 2015

@Tim-Anderson Can you have a look at that one?
(btw, maybe you can also add a general short section about the stop-on-error option in the README.md file)

fviard referenced this issue in Tim-Anderson/s3cmd Jul 18, 2015
This addresses s3tools#577

Signed-off-by: Tim Anderson <tsa@biglakesoftware.com>
@fviard
Copy link
Contributor Author

fviard commented Nov 5, 2017

Closed already fixed issue!

@fviard fviard closed this as completed Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant