Bug/curl #628
Merged
Bug/curl #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wget on RHEL6 is too old to implement --method=HEAD. curl works just fine.
In some places we were using the test_curl_HEAD() function, in others we were manually calling it. Instead, use the helper function everywhere. Add --location flag to curl command so that if S3 returns us a 302 redirect (which it may do for its own purposes), we follow it properly.
This adds a function similar to the shell 'which' command to detect if curl is available, rather than assuming curl is available on a posix system. Cleaner.
fviard
added a commit
that referenced
this pull request
Sep 17, 2015
Bug/curl. This replaces use of wget in run-tests.py with curl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces use of wget in run-tests.py with curl. wget doesn't work on RHEL 6 or RHEL 7 because it cannot issue only a HEAD call. curl can.