Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using maven-dependency-plugin version from parent since MDEP-753 fixed #367

Merged

Conversation

ao-apps
Copy link
Contributor

@ao-apps ao-apps commented Mar 15, 2022

Now using maven-dependency-plugin version 3.3.0 from parent, which fixes https://issues.apache.org/jira/browse/MDEP-753

This conflicts with PR #366 and makes #366 unnecessary.

The majority of the edits are related to the new versions inherited from parent-2.16.0

I added any keys referenced in this change to src/it/resources/local-repo/pgpkeys-cache, which I assume helps the tests work offline or when keyservers are down.

@ao-apps ao-apps marked this pull request as draft March 15, 2022 23:14
@ao-apps ao-apps marked this pull request as ready for review March 15, 2022 23:27
@ao-apps ao-apps marked this pull request as draft March 15, 2022 23:30
@ao-apps ao-apps force-pushed the use-maven-dependency-plugin-from-parent branch 6 times, most recently from 8bea9cd to c5fd514 Compare March 16, 2022 01:01
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ao-apps
Copy link
Contributor Author

ao-apps commented Mar 16, 2022

@slawekjaranowski Only one transient build failure remains, which is the same issue affecting the other builds. I hope this will meet your standards.

Thank you,

  • Dan

@ao-apps ao-apps marked this pull request as ready for review March 16, 2022 01:10
@ao-apps ao-apps force-pushed the use-maven-dependency-plugin-from-parent branch from c5fd514 to 75f73d4 Compare April 20, 2022 19:08
@ao-apps
Copy link
Contributor Author

ao-apps commented Apr 20, 2022

Rebased onto PR #369

dependabot bot and others added 2 commits April 20, 2022 19:15
Bumps [parent](https://github.com/s4u/parent) from 2.15.0 to 2.16.0.
- [Release notes](https://github.com/s4u/parent/releases)
- [Commits](s4u/parent@v2.15.0...v2.16.0)

---
updated-dependencies:
- dependency-name: org.simplify4u:parent
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@ao-apps ao-apps force-pushed the use-maven-dependency-plugin-from-parent branch from 75f73d4 to 276f247 Compare April 20, 2022 19:16
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ao-apps
Copy link
Contributor Author

ao-apps commented Apr 20, 2022

@slawekjaranowski rebased and ready-to-go

@slawekjaranowski slawekjaranowski merged commit 19d9ec3 into s4u:master Apr 20, 2022
@ao-apps ao-apps deleted the use-maven-dependency-plugin-from-parent branch April 20, 2022 19:43
@slawekjaranowski slawekjaranowski added the code quality Improvements, refactor or code cleanup. label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvements, refactor or code cleanup.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants