Moved pull implementation from stream.hpp to new file pull.hpp #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more major refactoring of stream.hpp, which is why I'm doing it on it's own branch, and initiating a pull request. This branch splits the implementation of stream and pull into separate files. It also removes the function
pull.toStream()
, which just invoked stream's constructor. This created an unnecessary cyclic dependency between the two classes. All instances ofpull.toStream()
were replaced with a direct call tostream
s constructor.Questions:
bot
(declared as an empty union), and how does it differ fromtop
(declared asusing top = std::monostate
)?eff.hpp
? It doesn't seem to do anything. It contained the definitions forbot
andtop
, but I moved those intostream.hpp
andpull.hpp
respectively.