Tracing #1
Merged
Tracing #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Swarvanu Sengupta <swarvanusg@gmail.com>
Signed-off-by: Swarvanu Sengupta <swarvanusg@gmail.com>
Due to some limitation we can't distribute the request span accross multiple phases Theres an open issue at: opentracing/specification#81 Once its resolved as intended we will be good to go For now we make a work around where we pass the last phase spanContext to show an waterfall pattern Signed-off-by: Swarvanu Sengupta <swarvanusg@gmail.com>
Signed-off-by: Swarvanu Sengupta <swarvanusg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge add a waterfall mode tracing for faaschain invocation
Due to some unresolved issue we can't extend the req span across all phases