Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security check Spartacus http fetching #44

Closed
ophian opened this issue Jul 27, 2013 · 5 comments
Closed

Security check Spartacus http fetching #44

ophian opened this issue Jul 27, 2013 · 5 comments

Comments

@ophian
Copy link
Member

ophian commented Jul 27, 2013

Quest: What about checksum check for security?
Answ.: Checksum-checks could be added, but of course this is some work to implement...

Anyone?

@yellowled
Copy link
Member

(Issue title adapted; these are all todos, 2.0 is signaled by the label already.)

@yellowled yellowled added this to the Stable milestone Mar 6, 2014
@garvinhicking garvinhicking removed the 2.0 label Apr 24, 2014
@yellowled yellowled modified the milestones: Future, Stable May 11, 2014
@yellowled yellowled modified the milestones: x.0.0, Future Jan 22, 2015
@garvinhicking
Copy link
Member

We can:

  • add a md5 checksum to the XML for our daily build
  • When a file is downloaded through Spartacus, build the MD5 of the local file and compare it to the remote XML checksum, probably return errors/alerts
  • Also add a check for each plugin file to our checksum comparison tool

Probable issues with this: This enlarges the XML about 10-15% I guess, which raises the PHP memory limit. The whole check will also take longer and more memory to parse, we might hit limits much earlier with this...

Another thing: We should add https:// to www.s9y.org and add it as a https:// mirror.

@yellowled
Copy link
Member

@garvinhicking You wanna revisit that statement after 5 months? :) Other than that, I would just close it.

@garvinhicking
Copy link
Member

We need to leave it open, it is still an issue.

@th-h
Copy link
Member

th-h commented Apr 27, 2019

Closed as WONTFIX after five years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants