lightbox 2.5.5: Avoid warning under PHP 8.0

s9y · Feb 28, 2023 · 17d9665 · 17d9665
1 parent 9614813
commit 17d9665
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/serendipity_event_lightbox/ChangeLog b/serendipity_event_lightbox/ChangeLog
@@ -1,3 +1,7 @@
+2.5.5:
+    *  Fix warning under PHP 8.0
+------------------------------------------------------------------------
+
 2.5.4:
     * Fix: Lightbox was not enabled in entries
 ------------------------------------------------------------------------

diff --git a/serendipity_event_lightbox/serendipity_event_lightbox.php b/serendipity_event_lightbox/serendipity_event_lightbox.php
@@ -25,7 +25,7 @@ function introspect(&$propbag)
         $propbag->add('name',           PLUGIN_EVENT_LIGHTBOX_NAME);
         $propbag->add('description',    PLUGIN_EVENT_LIGHTBOX_DESC);
         $propbag->add('author',         'Thomas Nesges, Andy Hopkins, Lokesh Dhakar, Cody Lindley, Stephan Manske, Grischa Brockhaus, Ian');
-        $propbag->add('version',        '2.5.4');
+        $propbag->add('version',        '2.5.5');
         $propbag->add('requirements',  array(
             'serendipity' => '1.6',
             'php'         => '5.3.0'
@@ -209,9 +209,9 @@ function event_hook($event, &$bag, &$eventData, $addData = null)
                     }
                     // LightBox2 jQuery based - http://lokeshdhakar.com/projects/lightbox2/ - this lightbox does not allow to show :visible anchors only - it shows and counts all gallery images, if set to view galleries
                     elseif ($type == 'lightbox2jq') {
-                        if ($headcss) {
-                            echo '    <link rel="stylesheet" type="text/css" href="' . $pluginDir . '/lightbox2-jquery/css/lightbox.css" />' . "\n";
-                        } else {
+                            if (isset($headcss) && $headcss) {
+                                echo '    <link rel="stylesheet" type="text/css" href="' . $pluginDir . '/lightbox2-jquery/css/lightbox.css" />' . "\n";
+                            } else {
                             if (!class_exists('serendipity_event_jquery') && !$serendipity['capabilities']['jquery']) {
                                 echo '    <script type="text/javascript" src="' . $pluginDir . '/jquery-1.11.3.min.js" charset="utf-8"></script>' . "\n";
                             }