Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip URI parameters when static page is looked up, so it can be found. #126

Merged
merged 2 commits into from
Jun 6, 2021

Conversation

hbarel
Copy link
Contributor

@hbarel hbarel commented May 21, 2021

No description provided.

@onli
Copy link
Member

onli commented May 28, 2021

Hi @hbarel . In my tests, this helps when the url is https://www.onli-blogging.de/index.php?/pages/kontakt.html?test=abc. But this looks wrong to me anyway. https://www.onli-blogging.de/index.php?/pages/kontakt.html&test=abc would be the construction I would expect to work, and that it does not for me.

I will leave your patch applied on my blog for easier testing.

Would you like to extend this patch to also handle &-params of the URL?

@hbarel
Copy link
Contributor Author

hbarel commented May 30, 2021

True... I never used "&" as first delimiter. See second commit.

@onli onli merged commit 9c9d9fb into s9y:master Jun 6, 2021
@onli
Copy link
Member

onli commented Jun 6, 2021

It is the second parameter :) See the ? after index.php. It's a bit hard to see with the parameter that follows being a path.

I merged this now, and will raise the version of the plugin in a separate commit. Thanks for the PR!

onli added a commit that referenced this pull request Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants