Check is_countable() before count() #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is_countable() would demand PHP >= 7.3.0 as of which it is available. See https://www.php.net/manual/en/function.is-countable.php Use a polyfill for PHP < 7.3.0 Loading serendipity_admin.php with $serendipity['production'] = false yielded a red alert box: The Serendipity JavaScript-library could not be loaded. This can happen due to PHP or Plugin errors, or even a malformed browser cache. To check the exact error please open https://.../index.php?/plugin/admin/serendipity_editor.js manually in your browser and check for error messages. Where at the end of that file could be found: == ERROR-REPORT (BETA/ALPHA-BUILDS) == <p><b>Warning:</b> count(): Parameter must be an array or an object that implements Countable in plugins/serendipity_event_linktrimmer/serendipity_event_linktrimmer.php on line 323.</p>
|
Let's keep this solution also in mind for the core, no? Could be useful there as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_countable() would demand PHP >= 7.3.0 as of which it is available.
See https://www.php.net/manual/en/function.is-countable.php
Use a polyfill for PHP < 7.3.0
Loading serendipity_admin.php with $serendipity['production'] = false
yielded a red alert box:
The Serendipity JavaScript-library could not be loaded. This can happen
due to PHP or Plugin errors, or even a malformed browser cache. To check
the exact error please open
https://.../index.php?/plugin/admin/serendipity_editor.js manually in
your browser and check for error messages.
Where at the end of that file could be found:
== ERROR-REPORT (BETA/ALPHA-BUILDS) ==
Warning: count(): Parameter must be an array or an object that implements Countable in plugins/serendipity_event_linktrimmer/serendipity_event_linktrimmer.php on line 323.