Recursive function #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhliu
requested changes
Mar 24, 2021
There was a problem hiding this comment.
https://github.com/sCrypt-Inc/boilerplate/tree/recurse
Writing is inconsistent with final_loop_main.scrypt.
contracts/final_loop_import.scrypt
Outdated
| library Aux { | ||
| static const int fee = 5000; | ||
| static const int SizeOfObject = 2; | ||
| static function my_great_function(Object object): DoNotTouch { |
contracts/final_loop_import.scrypt
Outdated
| } | ||
|
|
||
| //DO NOT MODIFY | ||
| struct DoNotTouch { |
There was a problem hiding this comment.
Rename DoNotTouch -> RecursiveReturn
contracts/final_loop_import.scrypt
Outdated
| } | ||
| return {{a, b}, recursion_call}; | ||
| } | ||
| static function bytes_to_object(bytes b): Object { |
contracts/final_loop_import.scrypt
Outdated
| static function bytes_to_object(bytes b): Object { | ||
| return {unpack(b[0:1]), unpack(b[1:2])}; | ||
| } | ||
| static function object_to_bytes(Object object): bytes { |
contracts/final_loop_import.scrypt
Outdated
| } | ||
|
|
||
|
|
||
| /* |
| //Do what you want after | ||
| require(true); | ||
| } | ||
| //Do not touch below |
| //Return everything util.scriptCode except the space we need in this library | ||
| return Util.readVarint(preimage[104:len(preimage)-Aux.SizeOfObject-1]); | ||
| } | ||
| static function buildOutput(SigHashPreimage preimage, bytes outputScript, int outputSatoshis): bytes { |
There was a problem hiding this comment.
Add empty line before each new function.
There was a problem hiding this comment.
@xhliu would it make sense to automate some of these checks with a linter? Or is there already one in place as part of the build / test process?
Closed
Closed
xhliu
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.