Fix cppcheck

[pinkenburg]

Types of changes

• [x ] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work for users)
• Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

cppcheck found a bad array initialization in TrkrClusterv1.cc which probably never affected the code. Fixed a few other benign cppcheck performance warnings

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

[sphenix-jenkins-ci]

Build & test report

Report for commit a5e4b2146c2aa45c2aa55a7bad588f5fc58588d4:

• builds and tests overall are SUCCESS.
• Build with configuration of gcc-8.3 / clang is SUCCESS, 📊clang report (full)/(new), build log
• Build with configuration of gcc-8.3 / new is SUCCESS, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS
    • 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 0.824329 / 72, and combined p-Value = 1
    • 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 0.0152029 / 72, and combined p-Value = 1
    • 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.573829 / 42, and combined p-Value = 1
    • 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 7.91824 / 42, and combined p-Value = 1
  • Tracking QA at high occupancy: build is SUCCESS
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 16, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = -0 / 38, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = -0 / 98, and combined p-Value = 1
  • Tracking QA at low occupancy: build is SUCCESS
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 16, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = -0 / 42, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = -0 / 98, and combined p-Value = 1
  • system gcc-8.3, build new: run the default sPHENIX macro: build is SUCCESS, output
  • system gcc-8.3, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system gcc-8.3, build new: Valgrind test: build is UNSTABLE, 📊valgrind report
• Build with configuration of gcc-8.3 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
• cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration