Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Accumulate modifications for new MVTX geometry and a lot of cleaning up" #733

Closed

Conversation

ycorrales
Copy link
Contributor

Add a class inherited from ALICE with real chip and sensor size
Implement new MVTX stave model and layer configuration, including rotation offset for the first stave
Remove much-unused code referring to ALICE OB detector.
Fix few bugs in the algorithm to determine the pixel index to/from location in the sensor.

Yasser Corrales Morales added 6 commits January 16, 2020 13:35
Using stave model from mvtx_stave_01.gdml which implements a more  realistic
description for Alpide chip and pixel dimentions.
Fix bug in pixel number from local sensor coords.
A new Mvtx configuration with latest values for layer radius and implementing
offset for the first stave in the layer.
@sPHENIX-bot sPHENIX-bot added CI-cpp-check-PENDING cpp-check is still running. CI-build-clang-PENDING build-clang is still running. CI-build-root5-PENDING build-root5 is still running. CI-build-new-PENDING build-new is still running. CI-build-root5-FAIL build-root5 failed! CI-DST-readback-PENDING DST-readback is still running. CI-valgrind-PENDING valgrind is still running. CI-DST-readback-PASS DST-readback passed. CI-calo-QA-PENDING calo-QA is still running. CI-cpp-check-AVAILABLE cpp-check result is available. and removed CI-build-root5-PENDING build-root5 is still running. CI-DST-readback-PENDING DST-readback is still running. CI-cpp-check-PENDING cpp-check is still running. labels Jan 16, 2020
@pinkenburg
Copy link
Contributor

I fixed the root5 crash and submitted another PR with this code, closing this one

@pinkenburg pinkenburg closed this Jan 16, 2020
@sPHENIX-bot sPHENIX-bot added CI-calo-QA-AVAILABLE calo-QA result is available. CI-valgrind-AVAILABLE valgrind result is available. CI-build-new-PASS build-new passed. CI-DST-readback-PENDING DST-readback is still running. CI-DST-readback-FAIL DST-readback failed! and removed CI-calo-QA-PENDING calo-QA is still running. CI-valgrind-PENDING valgrind is still running. CI-build-new-PENDING build-new is still running. CI-DST-readback-PASS DST-readback passed. labels Jan 16, 2020
@sPHENIX-bot sPHENIX-bot added CI-build-clang-FAIL build-clang failed! and removed CI-DST-readback-PENDING DST-readback is still running. CI-build-clang-PENDING build-clang is still running. labels Jan 16, 2020
@sPHENIX-bot
Copy link

Build & test report

Report for commit 9b69d2e49c3ea389ccb089ff7fbf87e2b8049317:


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@ycorrales ycorrales deleted the new_mvtx_sim branch January 17, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-build-clang-FAIL build-clang failed! CI-build-new-PASS build-new passed. CI-build-root5-FAIL build-root5 failed! CI-calo-QA-AVAILABLE calo-QA result is available. CI-cpp-check-AVAILABLE cpp-check result is available. CI-DST-readback-FAIL DST-readback failed! CI-valgrind-AVAILABLE valgrind result is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants