Added functionality to mark matched search term #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sa-si-dev
reviewed
Feb 4, 2021
sa-si-dev
reviewed
Feb 4, 2021
sa-si-dev
reviewed
Feb 4, 2021
sa-si-dev
requested changes
Feb 4, 2021
|
If you have interest, you can work on below feature. |
|
I've updated the pr with the changes you suggested. Thanks for taking the time to review this! |
|
I have already implemented #4 I will check in it soon. |
Perfect! I'll work on the other issue when I get some time. |
Thanks |
I will check and approve |
|
@frg I have moved the logic to set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to mark matched search term with the HTML tag
mark. The option is off by default to avoid breaking changes.