Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add region check #205

Merged
merged 17 commits into from
Sep 14, 2023
Merged

feat: add region check #205

merged 17 commits into from
Sep 14, 2023

Conversation

sa7mon
Copy link
Owner

@sa7mon sa7mon commented Sep 13, 2023

Changes

  • Add regioncheck cmd. This cmd is to be run periodically and for each provider that requires a client-per-region will:
    • make a request to the provider's documentation site or meta API to get a list of all available regions
    • compare that list of regions against the static list in provider/providers.go
    • if the lists differ, print the difference and exit with a code of 1
  • Add workflow to run the cmd on each PR. In the future, this may be changed to run on a regular schedule.

Closes #152

@sa7mon sa7mon added the feature label Sep 13, 2023
@sa7mon sa7mon linked an issue Sep 13, 2023 that may be closed by this pull request
@github-actions
Copy link

Code Coverage

Package Line Rate Complexity Health
github.com/sa7mon/s3scanner/bucket 90% 0
github.com/sa7mon/s3scanner/cmd/regioncheck 57% 0
github.com/sa7mon/s3scanner/cmd/s3scanner 19% 0
github.com/sa7mon/s3scanner/db 73% 0
github.com/sa7mon/s3scanner/permission 77% 0
github.com/sa7mon/s3scanner/provider 81% 0
github.com/sa7mon/s3scanner/worker 49% 0
Summary 64% (532 / 832) 0

@sa7mon sa7mon merged commit 30a15eb into main Sep 14, 2023
8 checks passed
@sa7mon sa7mon deleted the 152-region-check branch September 14, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create fetchRegions cmd
1 participant