Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: comments on jsx code snippet is regular html comments #1613

Closed
durosly opened this issue Feb 19, 2023 · 5 comments
Closed

docs: comments on jsx code snippet is regular html comments #1613

durosly opened this issue Feb 19, 2023 · 5 comments
Assignees

Comments

@durosly
Copy link

durosly commented Feb 19, 2023

On which page do you see this issue?

https://daisyui.com/components/table/

Describe the issue

Comments in JSX code snippets which is always written as

<!-- hello world -->

shoud be written as

{/* hello world */}

What browsers are you seeing the problem on?

No response

@adiitiii
Copy link
Contributor

Can i work on this issue, I'd really like to contribute

@saadeghi
Copy link
Owner

@adiitiii of course. Thank you 🙌

@durosly
Copy link
Author

durosly commented Feb 21, 2023

I would like to work on it too if it is not too late

@saadeghi
Copy link
Owner

@durosly it's just a simple text replacement so there's no need for competition 😅 If you can help with answering other issues/discussions or possibly helping to fix them I would really appreciate it.

@durosly
Copy link
Author

durosly commented Feb 21, 2023

@saadeghi No problem. I will see what else I can do

imgbot bot pushed a commit to Avensen/daisyui that referenced this issue Jun 5, 2023
* jsk-code-snippet

* jsk-code-snippet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants