Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove taiwan flag #2150

Closed
wants to merge 1 commit into from
Closed

Conversation

92hackers
Copy link

Hi, @saadeghi ,Thanks for your hard work to bring this awesome css lib to us developers.

This PR is just a fix to daisyui docs website, which make a mistake at TaiWan flag.

TaiWan is not a country, is essentially a province of China. currently it's a district because of some history reasons.

So, TaiWan flag should not be placed along with other REAL country flags, It's a big misleading to website visitors.


Besides, 繁体中文,not only spoken by taiwan people, but also HongKong people, Macao people and many overseas-chinese people.
so taiwan flag can not represents 繁体中文 at all.


My fix is to hidden taiwan flag, and preserve 繁体中文 name. below are screenshots showing brefore and after views:

Before:

Screen Shot 2023-07-19 at 5 55 56 PM

After:

Screen Shot 2023-07-19 at 6 47 25 PM

@saadeghi
Copy link
Owner

Hi, @saadeghi ,Thanks for your hard work to bring this awesome css lib to us developers.

Thank you 🙏

TaiWan is not a country

I have zero knowledge about the Chinese language. I know there are political disagreements but I would appreciate if you don't make a CSS library involved in politics.

The translation and the flag was added by people who are living there and I think you would agree that removing the flag would also lead people who are disagree with you, to get angry.

I really don't want to get into politics so I appreciate if you don't insist on this 🙏

Besides, 繁体中文,not only spoken by taiwan people, but also HongKong people, Macao people and many overseas-chinese people.
so taiwan flag can not represents 繁体中文 at all.

This is also true about other flags. A lot of countries speak English, Portuguese, Spanish, etc. The flags are just the commonly accepted icon for that. I understand that a language is not limited to one region or country.

Thank you for understanding

@saadeghi saadeghi closed this Jul 19, 2023
@NikarashiHatsu
Copy link
Contributor

I think it is unnecessary to remove the flag, besides the political reasons, it hurts the visual integrity.

@ikudev
Copy link

ikudev commented Jul 20, 2023

Edited: Please don't add more fuel to the fire. The PR is already closed and I don't want a political fight here. Thank you

Repository owner locked and limited conversation to collaborators Jul 20, 2023
@saadeghi
Copy link
Owner

I just want to add some information here.

Screenshot_2023-07-21-00-35-38-331_com android chrome

These are the language files and the file names are based on the ISO standards.
Most of the languages were added by open source contributors.
The file name for the mentioned language is zh_tw which is specifically for the Chinese language that people use in Taiwan (whether you believe it is a real country or not). If this translation is for Chinese speakers from Taiwan area, I don't see any issues with the flag because flags here are not representing countries.
Whether anyone believes Taiwan is a country or not (I don't care personally, sorry) no one can deny that it owns a flag.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants