Fixed emoji-render-issue using react-easy-emoji #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get latest Commits.
|
@kartik918 and @saadpasta Is there anything else that can be added to this PR. |
|
Can push changes on some domain |
kartikcho
requested changes
Apr 10, 2020
|
Also @saadpasta , let's squash every PR from now on before merging to avoid too many unnecessary commits on master branch. |
The site is live @ https://mknaveen.netlify.com/ |
|
There is no image icon showing with the emoji please fix that |
|
@saadpasta There was a bug in the library I used for adding SVG. So, for now, I have converted it to PNG and it will soon be deployed. |
|
Is the test build deployed now? |
|
Yeah, it is deployed on https://mknaveen.netlify.com/. |
kartikcho
requested changes
Apr 10, 2020
kartikcho
approved these changes
Apr 10, 2020
|
Good job Naveen! |
james-muriithi
pushed a commit
to james-muriithi/porfolio
that referenced
this pull request
Jun 9, 2020
* Added emoji render lib * Added react-easy-emoji Co-authored-by: Kartik Choudhary <kartikch918@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
I have fixed emoji render issue. From now on if the user needs to enter any emoji in
protofolio.js, the user should pass it as a parameter inemoji(). This solves the issue as it converts the emoji to an image so there is no problem.