Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added project requirements to contributing.md #79

Merged
merged 3 commits into from Oct 9, 2018
Merged

Added project requirements to contributing.md #79

merged 3 commits into from Oct 9, 2018

Conversation

esslamben
Copy link

Added Requirements to list of topics and added new requirement section just after project overview.

@saadq
Copy link
Owner

saadq commented Oct 8, 2018

Great work @Esslamb! After looking through the doc again, the note in the Setting Up section:

Note: You will need to have LaTeX installed on your machine if you wish to test out the resume generation. You can download it here.

should probably be moved into the requirements as well. Could you do that as well?

@esslamben
Copy link
Author

@saadq Yes of course! Updated that now mate. I made the LaTeX bullet point a link as I figured it's not as easy to find as node and npm.

@saadq
Copy link
Owner

saadq commented Oct 9, 2018

I agree, I think that's a good idea as well. But right now it's linking to my node-latex module which is just what I use to actually run the latex process, it isn't where you would need to download it from. The actual download link should be: https://www.latex-project.org/get/

Once that's fixed I think this is good to go!

@esslamben
Copy link
Author

Hey, @saadq this should be all done now. FYI I have a lot of react/js/node/go experience if you ever need additional help 👍

@saadq
Copy link
Owner

saadq commented Oct 9, 2018

Awesome, would definitely love to have more contributions! I'll be opening some more issues soon for things that need to be fixed/features that need to be added so keep a lookout on those and I can ping you if you'd like when I make them and you can work on them if any interest you.

@saadq saadq merged commit f795e37 into saadq:master Oct 9, 2018
@esslamben esslamben deleted the project-requirements branch October 9, 2018 19:42
@saadq
Copy link
Owner

saadq commented Feb 22, 2019

Late, but just wanted to let you know I've updated the README with the latest contributors and have added you. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants