Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

[WIP] experimenting with encrypted travis tokens #84

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

tansaku
Copy link
Contributor

@tansaku tansaku commented Mar 8, 2016

fixes #70

@tansaku
Copy link
Contributor Author

tansaku commented Mar 11, 2016

I wonder if we need to inject the token directly into the URL like so:

https://#{ENV.fetch("CI_USER_TOKEN")}@github.com/saasbook/hw-ruby-intro-ci.git

that would be a specific change for the CI which I think we should avoid ... what would be nice is some simpler way of checking whether this .netrc thing is doing what we think it should be doing ...

@bill-auger
Copy link
Member

i think with https:// git will always require a password for priveledged actions - i wouild assume you would need to write a private key to /home/travis/.ssh/ as a pre-build step and pull with ssh using the form git@github.com:saasbook/hw-ruby-intro-ci

@tansaku
Copy link
Contributor Author

tansaku commented Mar 11, 2016

maybe so @bill-auger but that's not what https://docs.travis-ci.com/user/private-dependencies/#API-Token implies ...

@tansaku tansaku force-pushed the 70_testing_with_secure_solutions branch from 2d8de4a to 5b13cd7 Compare March 14, 2016 10:25
@tansaku
Copy link
Contributor Author

tansaku commented Mar 14, 2016

We seem to have access to private repos now, but for some reason we get a single failure that seems unrelated to network access:

cucumber features/autograder_xqueue_stubbed.feature:47

passes locally for me - but on CI gets the following ...

/home/travis/build/saasbook/rag/lib/graders/feature_grader/lib/HW4feature.rb:151:in `rescue in run!': invalid cucumber results["Disabling profiles...\n", "\n", " *** ERROR: #<SystemExit: exit> *** \n", "Run options: --seed 25065\n", "\n", "# Running:\n", "\n", "\n", "\n", "Finished in 0.001856s, 0.0000 runs/s, 0.0000 assertions/s.\n", "\n", "0 runs, 0 assertions, 0 failures, 0 errors, 0 skips\n"] (StandardError)
    from /home/travis/build/saasbook/rag/lib/graders/feature_grader/lib/HW4feature.rb:161:in `run!'
    from /home/travis/build/saasbook/rag/lib/graders/feature_grader/lib/HW4feature.rb:45:in `block in total'
    from /home/travis/build/saasbook/rag/lib/graders/feature_grader/lib/HW4feature.rb:42:in `each'
    from /home/travis/build/saasbook/rag/lib/graders/feature_grader/lib/HW4feature.rb:42:in `total'
    from /home/travis/build/saasbook/rag/lib/graders/feature_grader/hw4_grader.rb:242:in `check_ref_cucumber'
    from /home/travis/build/saasbook/rag/lib/graders/feature_grader/hw4_grader.rb:109:in `block (2 levels) in runner_block'
    from /home/travis/build/saasbook/rag/lib/graders/feature_grader/hw4_grader.rb:332:in `time_operation'
    from /home/travis/build/saasbook/rag/lib/graders/feature_grader/hw4_grader.rb:105:in `block in runner_block'
    from /home/travis/build/saasbook/rag/lib/graders/feature_grader/hw4_grader.rb:76:in `chdir'
    from /home/travis/build/saasbook/rag/lib/graders/feature_grader/hw4_grader.rb:76:in `runner_block'
    from /home/travis/build/saasbook/rag/lib/auto_grader.rb:73:in `call'
    from /home/travis/build/saasbook/rag/lib/auto_grader.rb:73:in `block in run_in_subprocess'
    from /home/travis/build/saasbook/rag/lib/auto_grader.rb:69:in `fork'
    from /home/travis/build/saasbook/rag/lib/auto_grader.rb:69:in `run_in_subprocess'
    from /home/travis/build/saasbook/rag/lib/graders/feature_grader/hw4_grader.rb:55:in `grade'
    from /home/travis/build/saasbook/rag/lib/submission/base.rb:20:in `handle_submission'
    from /home/travis/build/saasbook/rag/lib/submission/polling.rb:19:in `block in run'
    from /home/travis/build/saasbook/rag/lib/submission/polling.rb:17:in `loop'
    from /home/travis/build/saasbook/rag/lib/submission/polling.rb:17:in `run'
    from /home/travis/build/saasbook/rag/features/step_definitions/adapter_x_queue_steps.rb:53:in `block (3 levels) in <top (required)>'
Submission message after grade: Your submission was recorded at 2010-06-19 18:52:28 +0000 : submission is on time.
Score: 0/100
There was a fatal error with your submission. It either timed out or caused an exception.
    Then I should receive a grade of "100" for my assignment           # features/step_definitions/adapter_x_queue_steps.rb:49
      expected: == 100.0
           got:    0.0 (RSpec::Expectations::ExpectationNotMetError)
      ./features/step_definitions/adapter_x_queue_steps.rb:57:in `/^I should receive a grade of "(.*?)" for my assignment$/'
      features/autograder_xqueue_stubbed.feature:51:in `Then I should receive a grade of "100" for my assignment'

@tansaku
Copy link
Contributor Author

tansaku commented Mar 17, 2016

@zhangaaron could you take a look at the above? many thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

too much data exposed here
2 participants