Ported FMI "feels like" temperature calculation. #52
Conversation
Bumped version to 0.2.1
There was a problem hiding this comment.
Thank you for the contribution and sorry for the delay! I was on vacation so took a while to check GitHub
It looks like the older version of pylint has a bug that makes it hate short variable names. And to be honest, I'm not a big fan of them either, except in loops 😄
The newer pylint fixes the issue, but it does not support Python 3.7. I could drop the support of 3.7 a bit later since it is already in end-of-life state, but for the time being I'd appreciate if you could change the code so that it makes the older pylint happy
|
One more request: could you please update README.md? "Feels like" is such a useful field it could be mentioned under "FMI provides the following commonly used information" |
|
Did updates. Should they be squashed into one commit - or kept as separate? Really up to you 😃 |
|
Awesome! Looks good! I'll merge this and release a new version after my workday Thanks again for the contribution! 🙏 |
|
Thanks! |
Added temperature "feels like" calculation based on FMI's original C code.
Bumped version to 0.2.1