[BUGFIX] Append content to existing file (#4226)

Resolves: #4225
sabbelasichon · Apr 11, 2024 · bc09faa · bc09faa
1 parent ac2a10b
commit bc09faa
Show file tree

Hide file tree

Showing 6 changed files with 36 additions and 3 deletions.
diff --git a/rules/TYPO312/v0/MoveAllowTableOnStandardPagesToTCAConfigurationRector.php b/rules/TYPO312/v0/MoveAllowTableOnStandardPagesToTCAConfigurationRector.php
@@ -119,12 +119,16 @@ private function writeConfigurationToFile(string $newConfigurationFile, string $
             '$GLOBALS[\'TCA\'][\'%s\'][\'ctrl\'][\'security\'][\'ignorePageTypeRestriction\'] = true;',
             $tableName
         );
-        $this->filesystem->write($newConfigurationFile, <<<CODE
+        if ($this->filesystem->fileExists($newConfigurationFile)) {
+            $this->filesystem->appendToFile($newConfigurationFile, $content . PHP_EOL);
+        } else {
+            $this->filesystem->write($newConfigurationFile, <<<CODE
 <?php
 
 {$content}
 
 CODE
-        );
+            );
+        }
     }
 }
diff --git a/src/Contract/FilesystemInterface.php b/src/Contract/FilesystemInterface.php
@@ -11,4 +11,6 @@ public function write(string $location, string $contents): void;
     public function fileExists(string $location): bool;
 
     public function read(string $location): string;
+
+    public function appendToFile(string $location, string $content): void;
 }
diff --git a/src/Filesystem/FlysystemFilesystem.php b/src/Filesystem/FlysystemFilesystem.php
@@ -33,4 +33,13 @@ public function read(string $location): string
     {
         return $this->filesystemOperator->read($location);
     }
+
+    public function appendToFile(string $location, string $content): void
+    {
+        $existingContent = $this->read($location);
+
+        $existingContent .= PHP_EOL . $content;
+
+        $this->write($location, $existingContent);
+    }
 }
diff --git a/...ToTCAConfigurationRector/Assertions/tx_table_with_existing_tca_configuration_file.php.inc b/...ToTCAConfigurationRector/Assertions/tx_table_with_existing_tca_configuration_file.php.inc
@@ -0,0 +1,5 @@
+<?php
+
+$GLOBALS['TCA']['other_table']['ctrl']['security']['ignorePageTypeRestriction'] = true;
+
+$GLOBALS['TCA']['tx_table_with_existing_tca_configuration_file']['ctrl']['security']['ignorePageTypeRestriction'] = true;
diff --git a/...r/v12/v0/MoveAllowTableOnStandardPagesToTCAConfigurationRector/Fixture/ext_tables.php.inc b/...r/v12/v0/MoveAllowTableOnStandardPagesToTCAConfigurationRector/Fixture/ext_tables.php.inc
@@ -5,7 +5,6 @@ namespace Ssch\TYPO3Rector\Tests\Rector\v12\v0\MoveAllowTableOnStandardPagesToTC
 use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
 
 ExtensionManagementUtility::allowTableOnStandardPages('tx_table_with_existing_tca_configuration_file');
-ExtensionManagementUtility::allowTableOnStandardPages('tx_table_with_existing_tca_configuration_file_and_security_key');
 ExtensionManagementUtility::allowTableOnStandardPages('tx_table_without_existing_tca_configuration_file');
 
 ?>

diff --git a/...gesToTCAConfigurationRector/MoveAllowTableOnStandardPagesToTCAConfigurationRectorTest.php b/...gesToTCAConfigurationRector/MoveAllowTableOnStandardPagesToTCAConfigurationRectorTest.php
@@ -19,12 +19,26 @@ protected function setUp(): void
 
     public function test(): void
     {
+        $this->filesystem->write(
+            __DIR__ . '/Fixture/Configuration/TCA/Overrides/tx_table_with_existing_tca_configuration_file.php',
+            <<<'CODE'
+<?php
+
+$GLOBALS['TCA']['other_table']['ctrl']['security']['ignorePageTypeRestriction'] = true;
+
+CODE
+        );
+
         $this->doTestFile(__DIR__ . '/Fixture/ext_tables.php.inc');
 
         $this->assertThatConfigurationFileHasNewIgnorePageTypeRestriction(
             __DIR__ . '/Fixture/Configuration/TCA/Overrides/%s.php',
             'tx_table_without_existing_tca_configuration_file'
         );
+        $this->assertThatConfigurationFileHasNewIgnorePageTypeRestriction(
+            __DIR__ . '/Fixture/Configuration/TCA/Overrides/%s.php',
+            'tx_table_with_existing_tca_configuration_file'
+        );
     }
 
     public function provideConfigFilePath(): string