Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Update Czech #889

Merged
merged 2 commits into from
Aug 25, 2023
Merged

i18n: Update Czech #889

merged 2 commits into from
Aug 25, 2023

Conversation

ceskyDJ
Copy link
Contributor

@ceskyDJ ceskyDJ commented Aug 25, 2023

No description provided.

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Aug 25, 2023

Hi, @adil192! I'm glad you're back and Saber development continues. Anyway, there is one question for this translation. You add a word "fit", so you wanted to change semantics to "How the image on a background is fitting", so how it's positioned, expanded, etc. Is it true?

@ceskyDJ ceskyDJ marked this pull request as draft August 25, 2023 17:21
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #889 (2043b53) into main (168ef7b) will not change coverage.
The diff coverage is n/a.

❗ Current head 2043b53 differs from pull request most recent head 6ee3915. Consider uploading reports for the commit 6ee3915 to get more accurate results

@@           Coverage Diff           @@
##             main     #889   +/-   ##
=======================================
  Coverage   35.93%   35.93%           
=======================================
  Files          93       93           
  Lines        6795     6795           
=======================================
  Hits         2442     2442           
  Misses       4353     4353           

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Aug 25, 2023

The Czech translation is something like "Positioning of the background image" now. Maybe something like more like "Adjusting of the background image" will be better. I'll change it.

@adil192
Copy link
Member

adil192 commented Aug 25, 2023

Hi, @adil192! I'm glad you're back and Saber development continues. Anyway, there is one question for this translation. You add a word "fit", so you wanted to change semantics to "How the image on a background is fitting", so how it's positioned, expanded, etc. Is it true?

Yes that's correct. This corresponds to the existing boxFit strings:
https://github.com/adil192/saber/blob/168ef7bdf0a8e2a132f609490d1efefe8efc1be4/lib/i18n/community/strings_cs.i18n.yaml#L256-L259

I will probably still be a little bit inactive until I return to uni (late September) since I'm not taking any notes right now

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Aug 25, 2023

I will probably still be a little bit inactive until I return to uni (late September) since I'm not taking any notes right now

I get it. We start already in the mid of September :D. I'm interesting you have pretty enough time for developing open-source in an academic year. I have almost no time after school projects, homework and these things comes.

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Aug 25, 2023

I'm sorry but I delay merging a bit. I'm not 100% sure about correctness of the translation, so I'll rethink it once more.

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Aug 25, 2023

I'll try "Layout of the background image" ("Rozložení obrázku na pozadí" in Czech), it sound as the best candidate (at least for now).

@ceskyDJ ceskyDJ marked this pull request as ready for review August 25, 2023 22:29
@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Aug 25, 2023

So, you can merge it.

@adil192
Copy link
Member

adil192 commented Aug 25, 2023

Thanks!

@adil192 adil192 merged commit 1842594 into saber-notes:main Aug 25, 2023
3 checks passed
@ceskyDJ ceskyDJ deleted the i18n-czech-bg-img-fit branch August 26, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants