Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick buttons borders fix & more #19

Merged
merged 5 commits into from
Jan 22, 2018
Merged

Quick buttons borders fix & more #19

merged 5 commits into from
Jan 22, 2018

Conversation

AlexAzumi
Copy link
Contributor

@AlexAzumi AlexAzumi commented Jan 21, 2018

Quick buttons borders were changed to fit inside the dialogbox and poems.

The chapter 30 had a syntaxis error in Monika's replicas, on the other hand, some changes were not merged because of me.

I'm so sorry :(

All quick buttons are inside the text box, even if using Developer Mode.

The previous code had a sintax error on the chapter 30. And finally, the characters menu can only be seen after playthrough 0.
Now quick buttons borders are ajusted to dialogbox. Ajusted also in poems.
All quick buttons are inside the text box, even if using Developer Mode.

The previous code had a syntax error on the chapter 30. And finally, the characters menu can only be seen after playthrough 0.
Now quick buttons borders are ajusted to dialogbox. Ajusted also in poems.
@saber-nyan saber-nyan self-assigned this Jan 21, 2018
Copy link
Owner

@saber-nyan saber-nyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@@ -193,7 +193,7 @@ define -2 gui.confirm_button_text_xalign = 0.5
define -2 gui.page_button_borders = Borders(10, 4, 10, 4)


define -2 gui.quick_button_text_size = 16
define -2 gui.quick_button_text_size = 19
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that the text of the Russian translation will fit in now...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh, I didn't think about translations, but it might not be a big deal.

@@ -312,7 +312,7 @@ label ch30_main2:
m "It kind of freaked me out, how easy it was."
m "Well, you're playing on Android, so it was actually a bit less difficult..."
m "I had to go to 'Settings' and find the 'Characters' button..." # TODOne: monika fix
elif renpy.macintosh:
if renpy.macintosh:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't notice.

@saber-nyan saber-nyan merged commit 06927b5 into saber-nyan:master Jan 22, 2018
@AlexAzumi AlexAzumi deleted the ui-fixes branch January 22, 2018 20:01
@saber-nyan saber-nyan mentioned this pull request Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants