Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

::selection #32

Closed
diomed opened this issue Aug 18, 2019 · 7 comments
Closed

::selection #32

diomed opened this issue Aug 18, 2019 · 7 comments

Comments

@diomed
Copy link
Contributor

diomed commented Aug 18, 2019

would you please add

::selection

color to template

so background would be mintcream or lavender or some nice color like that?

@krmax44
Copy link
Collaborator

krmax44 commented Aug 18, 2019

Hmm, for me there is a selection background color present... 😯
Bildschirmfoto von 2019-08-18 19-39-24

::selection {
@apply .bg-blue-500;
@apply .text-white;
}

@diomed
Copy link
Contributor Author

diomed commented Aug 18, 2019

but this is default.
like, without it, it still looks the same.
makes no sense.

@krmax44
Copy link
Collaborator

krmax44 commented Aug 18, 2019

It's Tailwind's default, yes. We could remove the ::selection selector as it's redundant. Feel free to open a PR :)

@diomed
Copy link
Contributor Author

diomed commented Aug 18, 2019

no.
I mean, this is default - when you hover anything in browser, even here on github, it shows the same.
point is to have other color than .bg-blue-500

@krmax44
Copy link
Collaborator

krmax44 commented Aug 18, 2019

Actually, it's a different color. The browser default for ::selection background color is CSS blue, or #0000ff, which is not the same as #4299e1 (Tailwind's blue-500).

@diomed
Copy link
Contributor Author

diomed commented Aug 18, 2019

please put

bg-blue-200 or bg-blue-100

instead. 500 is no good for ::selection - 2 dark

@krmax44
Copy link
Collaborator

krmax44 commented Aug 18, 2019

Sure, create a PR and we can compare the difference.

@krmax44 krmax44 closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants