Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlight plugin add support for line start #627

Merged
merged 2 commits into from
May 18, 2020

Conversation

Apostolique
Copy link
Contributor

@Apostolique Apostolique commented May 16, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

This PR makes it possible to start a code block from a different line number.

```js {lineNumbers:true,lineStart:5}
const cry = Array(3).fill('ora').join(' ')
```

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Closes #600

@vercel
Copy link

vercel bot commented May 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/saberland/saber/lmzbc9nhf
✅ Preview: https://saber-git-fork-apostolique-fix-600.saberland.now.sh

@egoist
Copy link
Collaborator

egoist commented May 18, 2020

Hi can you update the docs as well? https://saber.land/docs/markdown-features.html

@vercel vercel bot temporarily deployed to Preview May 18, 2020 17:44 Inactive
@egoist egoist merged commit 87232ac into saberland:master May 18, 2020
@Apostolique Apostolique deleted the fix/600 branch May 18, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Expose line number index for color highlighting
2 participants