Skip to content

Commit

Permalink
refs matomo-org#4278 Renames + New hook to let plugins modify idSites…
Browse files Browse the repository at this point in the history
… to archive
  • Loading branch information
mattab committed Nov 15, 2013
1 parent 3e5f6a5 commit c6d2177
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 6 deletions.
4 changes: 2 additions & 2 deletions core/Archive.php
Expand Up @@ -610,7 +610,7 @@ private function cacheArchiveIdsAfterLaunching($archiveGroups, $plugins)
continue;
}

$this->prepareArchives($archiveGroups, $site, $period);
$this->prepareArchive($archiveGroups, $site, $period);
}
}
}
Expand Down Expand Up @@ -779,7 +779,7 @@ private static function getPluginForReport($report)
* @param $site
* @param $period
*/
private function prepareArchives(array $archiveGroups, Site $site, Period $period)
private function prepareArchive(array $archiveGroups, Site $site, Period $period)
{
$parameters = new ArchiveProcessor\Parameters($site, $period, $this->params->getSegment());
$archiveLoader = new ArchiveProcessor\Loader($parameters);
Expand Down
8 changes: 5 additions & 3 deletions core/ArchiveProcessor.php
Expand Up @@ -365,6 +365,10 @@ protected function getOperationForColumns($columns, $defaultOperation)

protected function enrichWithUniqueVisitorsMetric(Row $row)
{
if(!$this->getParams()->isSingleSite() ) {
// we only compute unique visitors for a single site
return;
}
if ( $row->getColumn('nb_uniq_visitors') !== false) {
if (SettingsPiwik::isUniqueVisitorsEnabled($this->getParams()->getPeriod()->getLabel())) {
$uniqueVisitors = (float)$this->computeNbUniqVisitors();
Expand Down Expand Up @@ -470,9 +474,7 @@ protected function getAggregatedNumericMetrics($columns, $operationToApply)
if($rowMetrics === false) {
$rowMetrics = new Row;
}
if($this->getParams()->isSingleSite() ) {
$this->enrichWithUniqueVisitorsMetric($rowMetrics);
}
$this->enrichWithUniqueVisitorsMetric($rowMetrics);
$this->renameColumnsAfterAggregation($results);

$metrics = $rowMetrics->getColumns();
Expand Down
8 changes: 7 additions & 1 deletion core/ArchiveProcessor/Parameters.php
Expand Up @@ -14,6 +14,7 @@
use Piwik\Date;
use Piwik\Log;
use Piwik\Period;
use Piwik\Piwik;
use Piwik\Segment;
use Piwik\Site;

Expand Down Expand Up @@ -97,7 +98,12 @@ public function getSubPeriods()
public function getIdSites()
{
$idSite = $this->getSite()->getId();
return array($idSite);

$idSites = array($idSite);

Piwik::postEvent('ArchiveProcessor.Parameters.getIdSites', array( &$idSites ) );

return $idSites;
}

/**
Expand Down

0 comments on commit c6d2177

Please sign in to comment.