Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sable snapshot subcommand #26

Open
lino-levan opened this issue Sep 17, 2023 · 3 comments
Open

sable snapshot subcommand #26

lino-levan opened this issue Sep 17, 2023 · 3 comments

Comments

@lino-levan
Copy link
Contributor

We should support AoT compiled JS.

$ bueno snapshot mod.js
$ bueno run mod.snapshot
@lino-levan
Copy link
Contributor Author

Snapshots will most likely not be stable across bueno versions, so we should definitely note the current bueno version and warn that the snapshot was generated in an old version.

@Im-Beast
Copy link
Member

We'd need to think whether we would even support running them not-locally.
We'd also need to check if the snapshot has been compiled for current platform.

@Im-Beast
Copy link
Member

Also because snapshots would probably be susceptible to memory attacks we should require --allow-all as well as to warn the user about that

@lino-levan lino-levan changed the title bueno snapshot subcommand sable snapshot subcommand Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants