feat: fs operations in Bueno namespace #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #4 |
Im-Beast
reviewed
Aug 27, 2023
|
|
||
| // Testing: writeTextFileSync / readTextFileSync / removeSync | ||
| { | ||
| const text = "hello from your file system async"; |
Im-Beast
reviewed
Aug 27, 2023
There was a problem hiding this comment.
I'm not really sure whether we should store ops in an ops.rs file, I feel like we should group ops depending on what they do, so e.g. this should be renamed to fs.rs.
|
opening another PR, with conflicts fixed. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had no luck turning these into
op2s. Definitely something to do in a future PR.