build: bump solc and v2 core #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
approved these changes
Dec 19, 2023
PaulRBerg
force-pushed
the
build/bump-solc-and-v2-core
branch
from
63a35ff
to
35496d2
Compare
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #241 and #243 by upgrading V2 Core to v1.1.2 and the Solidity compiler to v0.8.23. Also closes #193.
I ended up bumping Solidity for the following reasons:
foundry.toml)DeployProtocolscript wouldn't work anymore (because of the viaIR bug)